Skip to content

refactor!: Drop pillow as a required dependency#1365

Merged
amaloney merged 9 commits intomainfrom
drop_pillow_required
Jan 28, 2025
Merged

refactor!: Drop pillow as a required dependency#1365
amaloney merged 9 commits intomainfrom
drop_pillow_required

Conversation

@hoxbro
Copy link
Copy Markdown
Member

@hoxbro hoxbro commented Oct 28, 2024

I am not completely sure we should drop it, but we should at least postpone the import until it is needed.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (f23de59) to head (eb9c886).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
datashader/tiles.py 25.00% 3 Missing ⚠️
datashader/tests/test_tiles.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.02%     
==========================================
  Files          93       93              
  Lines       18744    18750       +6     
==========================================
+ Hits        16595    16597       +2     
- Misses       2149     2153       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Happy to relax that requirement, as long as we clearly announce the change in the release notes. Thanks!

@hoxbro hoxbro added this to the v0.17.0 milestone Oct 31, 2024
@hoxbro hoxbro changed the title Drop pillow as a required dependency refactor!: Drop pillow as a required dependency Nov 10, 2024
@amaloney
Copy link
Copy Markdown
Collaborator

amaloney commented Jan 21, 2025

@amaloney note to look at dropping pillow or defer importing for now

  • note that bokeh depends on pillow

Copy link
Copy Markdown
Collaborator

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaloney amaloney merged commit 864836b into main Jan 28, 2025
@amaloney amaloney deleted the drop_pillow_required branch January 28, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants