Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update ruff and enable pyupgrade rules #1367

Merged
merged 11 commits into from
Oct 31, 2024
Merged

refactor: Update ruff and enable pyupgrade rules #1367

merged 11 commits into from
Oct 31, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 31, 2024

Bump ruff version and enable pyupgrade rules

@hoxbro hoxbro changed the title Update ruff Update ruff and enable pyupgrade rules Oct 31, 2024
@@ -26,7 +25,7 @@ class Type(type):
_registry = {}

def __new__(meta, name, bases, dct):
cls = super(Type, meta).__new__(meta, name, bases, dct)
cls = super(Type, meta).__new__(meta, name, bases, dct) # noqa: UP008
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure this is a safe fix, so I just ignored it.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (9cf38ff) to head (12bcee6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
datashader/mpl_ext.py 0.00% 4 Missing ⚠️
datashader/tiles.py 0.00% 3 Missing ⚠️
datashader/datashape/discovery.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
+ Coverage   88.57%   88.60%   +0.02%     
==========================================
  Files          93       93              
  Lines       18644    18620      -24     
==========================================
- Hits        16514    16498      -16     
+ Misses       2130     2122       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro changed the title Update ruff and enable pyupgrade rules refactor: Update ruff and enable pyupgrade rules Oct 31, 2024
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups, thanks!

@hoxbro hoxbro merged commit ebd2561 into main Oct 31, 2024
12 checks passed
@hoxbro hoxbro deleted the maint branch October 31, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants