-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 3D Volume regridding #946
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks!
|
||
Missing values (those having the value indicated by the | ||
"nodata" attribute of the raster) are replaced with `NaN` if | ||
floats, and 0 if int. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
floats, and 0 if int. | |
floats, and 0 if int. Thus if 0 is not a suitable missing-value indicator, | |
for your integer data, convert it to a float type before calling this method. |
nan_value : int or float, optional | ||
Optional nan_value which will be masked out when applying | ||
the resampling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nan_value : int or float, optional | |
Optional nan_value which will be masked out when applying | |
the resampling. | |
nan_value : int or float, optional | |
Optional nan_value that will be masked out when applying | |
the resampling. |
How does this interact with the "nodata" attribute of the raster? Does it override it? Should clarify that here.
Accepts an executable function, function object, or string name. | ||
interpolate : str, optional default=linear | ||
Resampling mode when upsampling raster. | ||
options include: nearest, linear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options include: nearest, linear. | |
Options include: nearest, linear. |
@philippjfr , can you compare your approach here with #927 and see if there is anything you need to take from here? I haven't tried to see how the two binning approaches differ or are similar. |
Having trouble seeing how they relate to each other. Isn't #927 going from points -> grids and this is going from grids -> grids? |
Right you are; this is 3D volume re-gridding, and the other is 3D volume gridding. So, the actual task is the other way around -- please check if anything from #927 is relevant to this one. Thanks! |
@philippjfr any update with this? Can we move forward? |
Implements basic 3D volume regridding only supporting mean downsampling and nearest upsampling for now.