Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cot to table #709

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Add cot to table #709

merged 6 commits into from
Sep 23, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Sep 20, 2024

Previously, it would take a detour to select the right table

  1. select the wrong table
  2. require a join
  3. don't perform a join; just use the supposed-to-be-joined table

Before:
image

Now, it directly reasons out the proper table:
image

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (905ac36) to head (01780b9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/agents.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   56.02%   56.02%   -0.01%     
==========================================
  Files          98       98              
  Lines       11828    11829       +1     
==========================================
  Hits         6627     6627              
- Misses       5201     5202       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 marked this pull request as ready for review September 20, 2024 23:09
@philippjfr philippjfr merged commit 780d98a into main Sep 23, 2024
10 checks passed
@philippjfr philippjfr deleted the add_cot_to_table branch September 23, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants