Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for utils and remove deprecated #727

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Add test for utils and remove deprecated #727

merged 11 commits into from
Oct 28, 2024

Conversation

ahuang11
Copy link
Contributor

Add tests one module at a time, starting with the utils

@ahuang11 ahuang11 changed the title Add test for utils and update deprecations Add test for utils and remove deprecated Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 99.01961% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (363f1f2) to head (5fd9c0e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lumen/tests/ai/test_utils.py 99.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
+ Coverage   54.42%   60.82%   +6.39%     
==========================================
  Files          99      100       +1     
  Lines       12203    12402     +199     
==========================================
+ Hits         6641     7543     +902     
+ Misses       5562     4859     -703     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ahuang11 ahuang11 merged commit 73fda79 into main Oct 28, 2024
11 checks passed
@ahuang11 ahuang11 deleted the add_test_for_utils branch October 28, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants