-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ruff d200 rule #983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
=======================================
Coverage 87.33% 87.33%
=======================================
Files 9 9
Lines 4928 4928
=======================================
Hits 4304 4304
Misses 624 624 ☔ View full report in Codecov by Sentry. |
@MarcSkovMadsen in case it wasn't clear, I did not suggest to open one PR per rule:
I think it's totally fine if you open one PR that enables multiple rules at the same time, specially if it's only about formatting. Things will get more challenging for reviewers as soon as you'll touch the real meat which is the content of the docstrings. cc @hoxbro |
7af55fb
to
622fd4a
Compare
c841a6b
to
acaab6c
Compare
acaab6c
to
c14fba2
Compare
Are you expecting me to squash and merge? |
It was a bit hard to rebase so maybe take a look that everything is ok and then merge it. |
Continues from #982. So review that one first.
I've re-renabled rule
D200
in pyproject.toml and appliedruff check --unsafe-fixes
.Then checked the changes manually.