-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 4 #114
Conversation
Wow, thank you @andrewfulton9, I owe you a beer or other beverage of your choice! I'll have a go at testing this tomorrow. |
I'm fine with removing dodo.py and install.json. We're moving away from |
427e19f
to
baee13b
Compare
Might also work on setting up some integration tests with Playwright that test Panel, HoloViews and the Panel Preview button work both in classic notebook and JupyterLab. |
I'm still trying to get all the checks passing. I'm at a bit of a loss for how to get the |
I can hopefully take a look soon, but likely not today. This seems to be pretty close, so already a huge thanks for all your efforts. |
No problem, thank you! |
@andrewfulton9 I run into the same issue and ended up adding |
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@philippjfr, have you gotten a chance to take a look at this? |
I had a brief look and then I suddenly had to organize a move of our apartment. Will be back to work Monday. |
This looks to be in great shape, I just removed the PR label check and made one small fix to the way disposing of rendered models is handled which regressed in JLab4 but otherwise I think this is ready. I'll merge once tests pass and then attempt a dev release. |
I'll merge despite the conda package release not being handled. I think we should move away from the pyviz channel in any case as we now have much more control over both defaults and conda-forge channel releases. If there is a strong need for it I may decide to restore it later, which is why I've not removed the recipe yet but that shouldn't hold up merge and releases. |
This PR upgrades pyviz_comms to be a jupyterlab4 extension. I've tested it by ensuring it builds successfully, the tests pass, and that I can run holoviz with it. Are there other tests I should run?
A couple of the things I am unsure about:
Thanks!