Skip to content

fix: bookmarks layout #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

fix: bookmarks layout #2675

merged 3 commits into from
Mar 28, 2025

Conversation

manuel-rw
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@manuel-rw manuel-rw self-assigned this Mar 22, 2025
@manuel-rw manuel-rw linked an issue Mar 22, 2025 that may be closed by this pull request
Copy link

deepsource-io bot commented Mar 22, 2025

Here's the code health analysis summary for commits 76b67ac..4a3ac3e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Mar 22, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.22% 10056 / 45252
🔵 Statements 22.22% 10056 / 45252
🔵 Functions 29.86% 428 / 1433
🔵 Branches 63.68% 1240 / 1947
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/widgets/src/bookmarks/component.tsx 0% 0% 0% 0% 1-290
Generated in workflow #5732 for commit 4a3ac3e by the Vitest Coverage Report Action

@manuel-rw manuel-rw force-pushed the fix/bookmarks-layout branch 7 times, most recently from 5b77ce2 to de5343a Compare March 28, 2025 17:24
@manuel-rw manuel-rw linked an issue Mar 28, 2025 that may be closed by this pull request
@manuel-rw manuel-rw marked this pull request as ready for review March 28, 2025 17:26
@manuel-rw manuel-rw requested a review from a team as a code owner March 28, 2025 17:26
@manuel-rw manuel-rw added the bug Something isn't working label Mar 28, 2025
@Meierschlumpf
Copy link
Member

If you are okay with the small change I did you can merge it

@manuel-rw manuel-rw merged commit 8a071f9 into dev Mar 28, 2025
12 of 13 checks passed
@Meierschlumpf Meierschlumpf deleted the fix/bookmarks-layout branch April 17, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Bookmarks in Vertical layout a mess in v1.11.0 bug: bookmark widget format scroll
2 participants