Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to synchronize automatically all available feeds in emoncms #128122

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

alexandrecuer
Copy link
Contributor

@alexandrecuer alexandrecuer commented Oct 10, 2024

Proposed change

Add possibility to synchronize all the available feeds without having to choose them one by one with the selector

image

If the manual option (default) is selected, next screen show the selector with the list of available feeds

image

if the auto option is selected, the entry is directly created with as many entries as available feeds in the emoncms instance

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @borpin, mind taking a look at this pull request as it has been labeled with an integration (emoncms) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of emoncms can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign emoncms Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@alexandrecuer alexandrecuer changed the title Add checkbox in options to sync all feeds once Add checkbox in options to sync all feeds once in emoncms Oct 11, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does once mean? They all get added to HA and then get synchronized all the time right?

@alexandrecuer
Copy link
Contributor Author

alexandrecuer commented Oct 11, 2024

What does once mean? They all get added to HA and then get synchronized all the time right?

Ýes exactly. That is something asked last week by some users at openenergymonitor.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 11, 2024 17:53
@alexandrecuer alexandrecuer marked this pull request as ready for review October 13, 2024 13:55
@home-assistant home-assistant bot requested a review from frenck October 13, 2024 13:55
@alexandrecuer alexandrecuer changed the title Add checkbox in options to sync all feeds once in emoncms Add possibility to synchronize automatically all the available feeds in emoncms Oct 14, 2024
@alexandrecuer alexandrecuer changed the title Add possibility to synchronize automatically all the available feeds in emoncms Add possibility to synchronize automatically all available feeds in emoncms Oct 14, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 10, 2024
@alexandrecuer alexandrecuer marked this pull request as draft November 11, 2024 16:36
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants