Adding support for new Lutron RGB tape light #130731
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @RBaragona
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-needed
integration: lutron_caseta
new-feature
small-pr
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @swails, @danaues, @eclair4151, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
Quality Scale: No score
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
Also to confirm, you'll need to wait until your pylutron-caseta PR Is merged, then raise 2 PRs here, the first just bumping the Python library version, and this is the second PR which can be merged after the first is merged. |
|
I agree and will link once the pylutron-caseta PR is merged. |
Update logic based on device types supporting warm dim and spectrum tune color.
|
@RBaragona I raised the PR for bumping the pylutron version |
|
@eclair4151 , I have tested and verified control with hardware as well. |
RBaragona
changed the title
| self.supports_warm_dim = light_type == DEVICE_TYPE_SPECTRUM_TUNE | ||
| self.supports_spectrum_tune = light_type == DEVICE_TYPE_SPECTRUM_TUNE | ||
| self.supports_warm_cool = self.supports_warm_dim = ( | ||
| light_type in WARM_DEVICE_TYPES |
There was a problem hiding this comment.
This is fine with me, but when I originally wrote the PR for ketra color, I was told not to let DEVICE_TYPE_WHITE_TUNE support Warm Dim this way, because Warm Dim should be controlled by a custom device feature, not using the built in 'white mode' as that was meant for something else.
I do have plans to raise another PR to move warm dim from white mode into its own feature, but if we are ok with making DEVICE_TYPE_WHITE_TUNE (light with temp control only, not RGB) supporting warm dim via white mode, then this is fine.
There was a problem hiding this comment.
Based on that previous feedback and your planned future work, I'd like to propose I roll this back. Any concerns @joostlek ?
Proposed change
Add support for new device type in Lutron-Caseta to enable support of new color and tunable white products.
Supported by integration via #134906
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: