Add option to allow to use setpoint instead of override for legacy incomfort RF gateway #135143
Conversation
jbouwh
changed the title
Is it possible to detect this? |
We can detect a serial number but cannot decide on the software version at the moment. |
| @@ -63,9 +78,60 @@ async def async_try_connect_gateway( | |||
| return None | |||
|
|
|||
|
|
|||
| class InComfortOptionsFlowHandler(OptionsFlow): | |||
There was a problem hiding this comment.
Let's put this one below the ConfigFlow
There was a problem hiding this comment.
The config flow holds a reference to the options flow, so it is easier to define the OptionFlowHandler first
| self.hass.config_entries.async_update_entry( | ||
| self.config_entry, options=new_options | ||
| ) | ||
| self.hass.async_create_task( | ||
| self.hass.config_entries.async_reload(self.config_entry.entry_id), | ||
| eager_start=False, | ||
| ) | ||
| return self.async_create_entry(data=new_options) |
There was a problem hiding this comment.
I know we have this helper for reauth, does it work for options flow as well?
There was a problem hiding this comment.
Reauth is for configflow, not for the option flow, but a helper would be a good idea for a new PR
There was a problem hiding this comment.
Oh I didn't mean the reload helper, I meant the update data and reload integration one
There was a problem hiding this comment.
I know, but this was another improvement
There was a problem hiding this comment.
As we want to class create entry, we do not want to reload and abort, as we do with reauth in the config flow.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Proposed change
Some older InComfort RF Gateways do not reset the override setting after the setpoint of a climate has changed manually. In that case the changed setpoint is not updated in Home Assistant. To work-a-round this issue this PR adds an option that allows to return the setpoint instead of the override. As side effect is though that when the setpoint is changed using the override, it will take some time for the climate to show the correct setpoint as the override attribute will be ignored.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: