-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reconfigure to LG webOS TV #135360
Add reconfigure to LG webOS TV #135360
Conversation
} | ||
}, | ||
"error": { | ||
"cannot_connect": "Failed to connect, please turn on your TV or check the IP address" | ||
"cannot_connect": "Failed to connect, please turn on your TV and try again.", | ||
"error_pairing": "Pairing failed, please try again." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to explain a bit more what happened?
Also from my experience setting up for the first time: Since the LG colors are purple and white, I did not know if purple was selected or white was selected, causing me to go through the setup multiple times and then I found out I had to switch to the "yes" button because it was not selected by default.
I am not sure if that is still relevant with newer models, but it would not surprise me if others had the same problem. It was a big facepalm moment for me haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say it is still not 100% clear even on newer models :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pairing failed, make sure to accept the pairing request on the TV and try again.
is it better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would work! I think it would at least point a bit to the "you are not accepting it" problem
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
oh ruff format is not happy |
Proposed change
MonkeyPatch
in all testsType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: