Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconfigure to LG webOS TV #135360

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Conversation

thecode
Copy link
Member

@thecode thecode commented Jan 11, 2025

Proposed change

  • Add reconfigure flow
  • Make all flows more graceful so that the user can retry if it fails
  • Remove usage of MonkeyPatch in all tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

homeassistant/components/webostv/config_flow.py Outdated Show resolved Hide resolved
}
},
"error": {
"cannot_connect": "Failed to connect, please turn on your TV or check the IP address"
"cannot_connect": "Failed to connect, please turn on your TV and try again.",
"error_pairing": "Pairing failed, please try again."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to explain a bit more what happened?

Also from my experience setting up for the first time: Since the LG colors are purple and white, I did not know if purple was selected or white was selected, causing me to go through the setup multiple times and then I found out I had to switch to the "yes" button because it was not selected by default.

I am not sure if that is still relevant with newer models, but it would not surprise me if others had the same problem. It was a big facepalm moment for me haha

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say it is still not 100% clear even on newer models :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pairing failed, make sure to accept the pairing request on the TV and try again. is it better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would work! I think it would at least point a bit to the "you are not accepting it" problem

@home-assistant home-assistant bot marked this pull request as draft January 11, 2025 11:58
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

thecode and others added 2 commits January 11, 2025 14:04
@thecode thecode marked this pull request as ready for review January 11, 2025 12:15
@home-assistant home-assistant bot requested a review from joostlek January 11, 2025 12:15
@joostlek
Copy link
Member

oh ruff format is not happy

@joostlek joostlek merged commit a745e07 into home-assistant:dev Jan 11, 2025
34 checks passed
@thecode thecode deleted the webostv-reconfigure branch January 11, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants