Avoid import dhcp, ssdp, zeroconf in config_flow.py when only used for type checking #135373
+582
−310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Some users might not use the default_config and avoid loading dhcp, ssdp or zeroconf. Currently, due to type checking, dhcp, ssdp or zeroconf will still be imported. This patch avoids this import (while keeping the annotation).
This is my first PR, and because I applied the same fix to all integrations, this patch might be bigger and touching a lot of integrations. I'm willing to split it up (but would prefer to avoid creating one PR per integration...)
Methodology used:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: