Skip to content

Comments

Add MatterMeterSensor class for enhanced Matter sensor representation#147402

Closed
3reality-wangzhijie wants to merge 2 commits intohome-assistant:devfrom
3reality-wangzhijie:fix-plug
Closed

Add MatterMeterSensor class for enhanced Matter sensor representation#147402
3reality-wangzhijie wants to merge 2 commits intohome-assistant:devfrom
3reality-wangzhijie:fix-plug

Conversation

@3reality-wangzhijie
Copy link

@3reality-wangzhijie 3reality-wangzhijie commented Jun 24, 2025

Apply multiplier and divisor against CurrentSummationDelivered attribute

depend on matter-js/python-matter-server#1180

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @3reality-wangzhijie

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare
Copy link
Member

I'm marking this PR as draft as this PR depends on a library change.

@MartinHjelmare MartinHjelmare marked this pull request as draft June 26, 2025 15:13
@marcelveldt
Copy link
Member

@3reality-wangzhijie we are now running a beta of matter server with the fix included, expect a stable release soon. After that the lib can be bumped here as well and this PR unblocked.

BTW: Soon we will make it a bit easier to define the custom clusters by containing them in a dedicated repository.

@Apollon77
Copy link
Contributor

I guess the release is out in the meantime?

@lboue
Copy link
Contributor

lboue commented Aug 28, 2025

I guess the release is out in the meantime?

Yes: https://github.com/matter-js/python-matter-server/releases/tag/8.1.0

@emontnemery
Copy link
Contributor

@marcelveldt @3reality-wangzhijie what is this PR waiting for? python-matter-server was bumped to version 8.1.0 in PR #150631

@lboue
Copy link
Contributor

lboue commented Sep 25, 2025

  1. This branch has conflicts that must be resolved
  2. 2 errors to fix:
  • Error: homeassistant/components/matter/sensor.py:726: error: "type[Attributes]" has no attribute "Multiplier" [attr-defined]
  • Error: homeassistant/components/matter/sensor.py:727: error: "type[Attributes]" has no attribute "Divisor" [attr-defined]
  1. Add fixture and update snapshots

@lboue
Copy link
Contributor

lboue commented Oct 2, 2025

@3reality-wangzhijie Does this request still make sense?

@lboue lboue closed this Oct 6, 2025
@lboue
Copy link
Contributor

lboue commented Oct 6, 2025

Inactive for several months.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants