Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera support to synology_dsm #39838

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Conversation

shenxn
Copy link
Contributor

@shenxn shenxn commented Sep 9, 2020

Proposed change

This PR adds camera support to the synology_dsm integration. After this integration, we should deprecated the synology integration since that is no longer needed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as its been labeled with an integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

homeassistant/components/synology_dsm/camera.py Outdated Show resolved Hide resolved
homeassistant/components/synology_dsm/camera.py Outdated Show resolved Hide resolved
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice to me, will test before approval.

homeassistant/components/synology_dsm/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/synology_dsm/__init__.py Outdated Show resolved Hide resolved
@Quentame
Copy link
Member

Quentame commented Sep 9, 2020

get snapshot image worked well but live stream got stuck.

http://IP:PORT/webapi/entry.cgi?api=SYNO.SurveillanceStation.Stream.VideoStreaming&version=1&method=Stream&format=mjpeg&cameraId=1&StmKey="a4b710d547bf21275eb59143497fd9db" does not respond.

Investivating...

Almost the same as a synology issue #39813

@shenxn
Copy link
Contributor Author

shenxn commented Sep 9, 2020

@Quentame I think the code uses rtsp streaming instead of the mjpeg one. Can you try the rtsp address?

@Quentame
Copy link
Member

Quentame commented Sep 9, 2020

@Quentame I think the code uses rtsp streaming instead of the mjpeg one. Can you try the rtsp address?

I will

@Quentame
Copy link
Member

Apparently a new version of the frontend fixes this issue, see : #39813 (comment)

So I'll rebase your branch locally and see if this works.

@Quentame
Copy link
Member

Working after a rebase

Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks a lot 😊

@Quentame Quentame merged commit b66aaee into home-assistant:dev Sep 10, 2020
@Quentame
Copy link
Member

Emmmm, it was quick 😅

I think we should add some doc @shenxn !

@shenxn shenxn deleted the synology-camera branch September 11, 2020 08:33
@shenxn
Copy link
Contributor Author

shenxn commented Sep 11, 2020

I created a PR for doc. Now I think it's time to deprecated the synology integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants