-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add camera support to synology_dsm #39838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems nice to me, will test before approval.
get snapshot image worked well but live stream got stuck.
Investivating... Almost the same as a |
@Quentame I think the code uses rtsp streaming instead of the mjpeg one. Can you try the rtsp address? |
I will |
Apparently a new version of the frontend fixes this issue, see : #39813 (comment) So I'll rebase your branch locally and see if this works. |
Working after a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks a lot 😊
Emmmm, it was quick 😅 I think we should add some doc @shenxn ! |
I created a PR for doc. Now I think it's time to deprecated the |
Proposed change
This PR adds camera support to the
synology_dsm
integration. After this integration, we should deprecated thesynology
integration since that is no longer needed.Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: