Skip to content

Fix check_config script#5853

Merged
balloob merged 1 commit intohome-assistant:devfrom
pvizeli:fix_sign_error
Feb 10, 2017
Merged

Fix check_config script#5853
balloob merged 1 commit intohome-assistant:devfrom
pvizeli:fix_sign_error

Conversation

@pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 10, 2017

Description:

@andrey-git can you test it? I'm not sure if I mock on correct way.

Should fix this:

Exception ignored in: <bound method _UnixSelectorEventLoop.__del__ of <_UnixSelectorEventLoop running=False closed=True debug=False>>
Traceback (most recent call last):
  File "/srv/hass/lib/python3.4/site-packages/asyncio/base_events.py", line 361, in __del__
  File "/srv/hass/lib/python3.4/site-packages/asyncio/unix_events.py", line 57, in close
  File "/srv/hass/lib/python3.4/site-packages/asyncio/unix_events.py", line 138, in remove_signal_handler
TypeError: signal handler must be signal.SIG_IGN, signal.SIG_DFL, or a callable object

Related issue (if applicable): fixes #5851

@mention-bot
Copy link

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @kellerza and @fabaff to be potential reviewers.

@pvizeli pvizeli added this to the 0.38 milestone Feb 10, 2017
@kellerza
Copy link
Member

Who broke it? Might be better to add a unit test so that it cannot happen again

@balloob
Copy link
Member

balloob commented Feb 10, 2017

@kellerza you want to add a test for the test? :D

@balloob balloob merged commit 4e8d203 into home-assistant:dev Feb 10, 2017
@kellerza
Copy link
Member

But this "fix" is for bootstrap tests and a new feature in check_config

So there are no tests for the new check_config silence (or reason why not silencing it fails)

@pvizeli
Copy link
Member Author

pvizeli commented Feb 10, 2017

Sorry I mix two stuff in one PR. The bootstrap was not effected with check config

balloob pushed a commit that referenced this pull request Feb 11, 2017
@balloob
Copy link
Member

balloob commented Feb 11, 2017

cherry-picked

@home-assistant home-assistant locked and limited conversation to collaborators May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants