Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for proposed new intergration: Hue BLE #33042

Open
wants to merge 13 commits into
base: next
Choose a base branch
from

Conversation

flip-dots
Copy link

@flip-dots flip-dots commented Jun 2, 2024

Proposed change

This adds documentation for the proposed new integration HueBLE.
home-assistant/core#118635

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Added support for Philips Hue Bluetooth lights integration, titled "Hue BLE"
    • Introduced configuration flow for easy setup through Home Assistant
    • Supports local push communication for enhanced connectivity
  • Documentation

    • Provided initial setup instructions for pairing Philips Hue lights
    • Detailed compatibility information for the "Hue White and Color 1100" model
    • Included metadata for improved integration structure and accessibility

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jun 2, 2024
Copy link

netlify bot commented Jun 2, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 261943c
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6794d3d8bfe4940008319a27
😎 Deploy Preview https://deploy-preview-33042--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

source/_integrations/hue_ble.markdown Outdated Show resolved Hide resolved
source/_integrations/hue_ble.markdown Show resolved Hide resolved
source/_integrations/hue_ble.markdown Outdated Show resolved Hide resolved
source/_integrations/hue_ble.markdown Outdated Show resolved Hide resolved
source/_integrations/hue_ble.markdown Outdated Show resolved Hide resolved
source/_integrations/hue_ble.markdown Outdated Show resolved Hide resolved
source/_integrations/hue_ble.markdown Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Jun 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 3, 2024 09:52
@c0ffeeca7 c0ffeeca7 added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 3, 2024
@c0ffeeca7
Copy link
Contributor

@flip-dots, please link the related brands PR.

@flip-dots
Copy link
Author

I updated the request with the brands PR but ill put it here for convinience as well
home-assistant/brands#5534

@flip-dots flip-dots requested a review from c0ffeeca7 June 3, 2024 18:47
@flip-dots flip-dots marked this pull request as ready for review June 3, 2024 18:47
Copy link
Contributor

coderabbitai bot commented Jan 25, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a new integration for controlling Philips Hue Bluetooth lights within Home Assistant, named "Hue BLE." It includes comprehensive documentation detailing setup instructions, the necessity of pairing mode via the Hue app, and supported models like the Hue White and Color 1100 (LCA006). The integration supports local push communication and Bluetooth connectivity, with a configuration flow available through the Home Assistant interface.

Changes

File Change Summary
source/_integrations/hue_ble.markdown Added new integration documentation for Hue BLE lights, including setup instructions, supported models, and metadata details such as title, description, and release version.

Sequence Diagram

sequenceDiagram
    participant User
    participant HueApp
    participant HomeAssistant
    participant HueBLELight

    User->>HueApp: Put light in pairing mode
    HueApp->>HueBLELight: Enable Bluetooth discovery
    User->>HomeAssistant: Start integration setup
    HomeAssistant->>HueBLELight: Discover and connect via Bluetooth
    HueBLELight-->>HomeAssistant: Establish connection
    HomeAssistant->>User: Integration setup complete
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (6)
source/_integrations/hue_ble.markdown (6)

3-3: Improve the description field.

The description contains a typo in "Phillips" (should be "Philips") and could be more descriptive about the integration's capabilities.

-description: Instructions on how to setup Phillips Hue Bluetooth lights within Home Assistant.
+description: Instructions on how to integrate and control Philips Hue Bluetooth lights locally within Home Assistant.

18-18: Fix the brand name spelling.

The brand name "Phillips" should be "Philips".

-The **Hue BLE** {% term integration %} allows you to control your Phillips Hue Bluetooth lights with Home Assistant.
+The **Hue BLE** {% term integration %} allows you to control your Philips Hue Bluetooth lights with Home Assistant.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~18-~18: Did you mean “Philips Hue”?
Context: ...tegration %} allows you to control your Phillips Hue Bluetooth lights with Home Assistant. ...

(EN_SIMPLE_REPLACE_PHILLIPS_HUE)


19-20: Remove extra blank line.

There are multiple consecutive blank lines. Keep only one blank line for consistency.

-

-
+
🧰 Tools
🪛 Markdownlint (0.37.0)

20-20: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


25-25: Improve sentence structure with proper punctuation.

Add a comma after "Home Assistant" for better readability.

-Before trying to connect your light(s) to Home Assistant you must put the light(s) into pairing mode in the Hue app ([Android](https://play.google.com/store/apps/details?id=com.philips.lighting.hue2), [iOS](https://apps.apple.com/us/app/philips-hue/id1055281310)).
+Before trying to connect your light(s) to Home Assistant, you must put the light(s) into pairing mode in the Hue app ([Android](https://play.google.com/store/apps/details?id=com.philips.lighting.hue2), [iOS](https://apps.apple.com/us/app/philips-hue/id1055281310)).
🧰 Tools
🪛 LanguageTool

[uncategorized] ~25-~25: Possible missing comma found.
Context: ...trying to connect your light(s) to Home Assistant you must put the light(s) into pairing ...

(AI_HYDRA_LEO_MISSING_COMMA)


38-39: Add instructions for reporting compatibility.

Provide clear instructions on how users can report working models.

-This {% term integration %} is tested to work with the following models but has been designed to work with other models. If you have a different model and it is working, please let us know.
+This {% term integration %} is tested to work with the following models but has been designed to work with other models. If you have a different model that works, please report it in the [Home Assistant Community Forum](https://community.home-assistant.io/) or create a pull request to update this documentation.

18-18: Add references to related PRs.

For better traceability, add links to the related PRs in the core and brands repositories.

The **Hue BLE** {% term integration %} allows you to control your Philips Hue Bluetooth lights with Home Assistant.
+
+This integration is part of the following pull requests:
+- [Core integration PR #118635](https://github.com/home-assistant/core/pull/118635)
+- [Brands PR #5534](https://github.com/home-assistant/brands/pull/5534)
🧰 Tools
🪛 LanguageTool

[uncategorized] ~18-~18: Did you mean “Philips Hue”?
Context: ...tegration %} allows you to control your Phillips Hue Bluetooth lights with Home Assistant. ...

(EN_SIMPLE_REPLACE_PHILLIPS_HUE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 984de61 and eea58ad.

📒 Files selected for processing (1)
  • source/_integrations/hue_ble.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/hue_ble.markdown

[uncategorized] ~18-~18: Did you mean “Philips Hue”?
Context: ...tegration %} allows you to control your Phillips Hue Bluetooth lights with Home Assistant. ...

(EN_SIMPLE_REPLACE_PHILLIPS_HUE)


[uncategorized] ~25-~25: Possible missing comma found.
Context: ...trying to connect your light(s) to Home Assistant you must put the light(s) into pairing ...

(AI_HYDRA_LEO_MISSING_COMMA)

🪛 Markdownlint (0.37.0)
source/_integrations/hue_ble.markdown

20-20: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/hue_ble.markdown (1)

45-49: LGTM!

The removal instructions are clear and follow the standard documentation format.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_integrations/hue_ble.markdown (3)

28-28: Add missing comma for better readability.

Add a comma after "pairing mode" to improve sentence structure.

-When the light is in pairing mode you may proceed to connect to it with Home Assistant.
+When the light is in pairing mode, you may proceed to connect to it with Home Assistant.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~28-~28: Possible missing comma found.
Context: ...erable**. When the light is in pairing mode you may proceed to connect to it with H...

(AI_HYDRA_LEO_MISSING_COMMA)


37-38: Add link for reporting compatible models.

Consider adding a link to guide users on where to report compatible models (e.g., GitHub issues or discussions).

-This {% term integration %} is tested to work with the following models but has been designed to work with other models. If you have a different model and it is working, please let us know.
+This {% term integration %} is tested to work with the following models but has been designed to work with other models. If you have a different model and it is working, please [open an issue](https://github.com/home-assistant/core/issues/new?labels=integration%3A+hue_ble) to let us know.

18-18: Add reference to the brands repository PR.

Consider adding a note about the integration's icons and logos being available through the brands repository.

The **Hue BLE** {% term integration %} allows you to control your Philips Hue Bluetooth lights with Home Assistant.

+<div class='note'>
+Icons and logos for this integration are available through the [brands repository](https://github.com/home-assistant/brands/pull/5534).
+</div>
+
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eea58ad and 339c025.

📒 Files selected for processing (1)
  • source/_integrations/hue_ble.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/hue_ble.markdown

[uncategorized] ~28-~28: Possible missing comma found.
Context: ...erable**. When the light is in pairing mode you may proceed to connect to it with H...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (4)
source/_integrations/hue_ble.markdown (4)

1-16: LGTM! Metadata is well-structured and complete.

The YAML frontmatter contains all the necessary fields and follows Home Assistant's documentation standards.


18-18: LGTM! Introduction is clear and consistent.

The introduction effectively describes the integration's purpose, and the naming convention "Hue BLE" is consistently used.


32-32: LGTM! Config flow section is properly placed.

The configuration flow template is correctly included and appropriately positioned after the initial setup instructions.


44-48: LGTM! Removal instructions are clear and complete.

The removal section correctly includes both custom instructions and the standard template.

flip-dots and others added 13 commits January 25, 2025 12:06
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants