Remove USB stack patches working around obsoleted Z-Wave devices issues #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sairon
force-pushed
the
drop-usb-core-patch
branch
from
bff99ea to
4e51a38
Compare
In #3224 we've introduced a patch reverting some changes in the USB stack that was supposed to work around issues with some USB devices. Later discussions revealed these devices are obsoleted by the manufacturer and there is no official way of fixing those in newer Linux kernels. However, carrying the patches makes us diverge from upstream and can eventually trigger other problems not present upstream we'll have to handle. Drop these patches now to be part of the upcoming OS 15 release, rather than needing to drop them later in any of the patch revisions later.
📝 WalkthroughWalkthroughThe changes remove patch files that had previously reverted USB core modifications meant to address issues with the Z-Wave.me UZB stick. The rollback undoes alterations to SuperSpeed initialization, race conditions in hub port descriptor handling, and API changes for retrieving device descriptors. Additionally, the method signature for Changes
Sequence Diagram(s)sequenceDiagram
participant Driver
participant USB_Core
participant USB_Device
Driver->>+USB_Core: Call usb_get_device_descriptor(dev, size)
USB_Core->>+USB_Device: Request device descriptor
USB_Device-->>-USB_Core: Returns descriptor data
USB_Core-->>-Driver: Returns descriptor data or error code
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
sairon
changed the title
agners
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3224 we've introduced a patch reverting some changes in the USB stack that was supposed to work around issues with some USB devices. Later discussions revealed these devices are obsoleted by the manufacturer and there is no official way of fixing those in newer Linux kernels. However, carrying the patches makes us diverge from upstream and can eventually trigger other problems not present upstream we'll have to handle.
Drop these patches now to be part of the upcoming OS 15 release, rather than needing to drop them later in any of the patch revisions later.
Summary by CodeRabbit