Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check run in case no version was provided #32

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

isibeni
Copy link
Contributor

@isibeni isibeni commented Aug 25, 2023

Fail early if no run was provided

@isibeni isibeni changed the title fix check resource Fix check run in case no version was provided Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.67% 🎉

Comparison is base (f80246c) 82.17% compared to head (04914b8) 82.85%.

❗ Current head 04914b8 differs from pull request most recent head cfa744f. Consider uploading reports for the commit cfa744f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   82.17%   82.85%   +0.67%     
==========================================
  Files           4        4              
  Lines         101      105       +4     
==========================================
+ Hits           83       87       +4     
  Misses         12       12              
  Partials        6        6              
Flag Coverage Δ
unittests 82.85% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/dtr/check.go 86.36% <100.00%> (+3.03%) ⬆️
internal/dtr/common.go 94.73% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fail early if no run was provided
@HeavyWombat HeavyWombat merged commit 6c4b9f9 into homeport:main Aug 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants