fix: try to better manage internal server error when user not granted + CI with CircleCI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylascombe
force-pushed
the
INFRABUILD-3482_fix_internal_server_error
branch
from
549c4a3 to
8a27d93
Compare
Hosade
reviewed
Jul 18, 2024
ylascombe
changed the title
Co-authored-by: Romain Boutinaud <119870889+Hosade@users.noreply.github.com>
Hosade
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When user not belong to expected github team, the new behavior since upgrade is to return a 500 error "internal server error". The previous behavior, and expected one is to reach a 403 "permission denied"
Motivation and Context
How Has This Been Tested?
Checklist: