maint: Replace baggage span processor with OTel version #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
codeboten
approved these changes
May 8, 2024
|
We're not going to go ahead with this for now as it requires users to also ignore the NU1605 warning. This is because the new OTel baggage processor requires the latest SDK version 1.8.1 and we don't want to move our distro beyond 1.6.0 for HTTP semcomv breaking changes. We'll come back to this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Replaces the distro's custom baggage span processor with the newly contributed OTel baggage activity processor.
Short description of the changes
NU1605to ignore the dependency requirement of the new package - we don't want to move past 1.6.0 to preserve HTTP semcomv compatability - see here