fix: count the number of IDs in drop decision messages #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like we actually want two metrics - one for the number of drop messages, and one for the number of items dropped in response to that. Both are going to be useful to us. |
VinozzZ
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The counts for drop and kept decisions are based on the number of messages received. However, because drop decisions are actually a set of Trace IDs vs kept which is per trace, the counts do correlate with each other.
For example, the below query shows around 17 drop messages per minute, while the kept decision count is around 2200.
This PR updates the drop count to count the number of IDs in the drop messages, which will give a real representation of the number of drop decisions.
Short description of the changes
drop_decisions_receivedcounter to count the number of IDs in the message