perf(mime): make getExtension() fast (#2168)

honojs · Feb 8, 2024 · 88a82ba · 88a82ba
1 parent 7072927
commit 88a82ba
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/deno_dist/utils/mime.ts b/deno_dist/utils/mime.ts
@@ -12,7 +12,11 @@ export const getMimeType = (filename: string, mimes = baseMimes): string | undef
 }
 
 export const getExtension = (mimeType: string): string | undefined => {
-  return Object.keys(baseMimes).find((ext) => baseMimes[ext] === mimeType)
+  for (const ext in baseMimes) {
+    if (baseMimes[ext] === mimeType) {
+      return ext
+    }
+  }
 }
 
 const baseMimes: Record<string, string> = {

diff --git a/src/utils/mime.ts b/src/utils/mime.ts
@@ -12,7 +12,11 @@ export const getMimeType = (filename: string, mimes = baseMimes): string | undef
 }
 
 export const getExtension = (mimeType: string): string | undefined => {
-  return Object.keys(baseMimes).find((ext) => baseMimes[ext] === mimeType)
+  for (const ext in baseMimes) {
+    if (baseMimes[ext] === mimeType) {
+      return ext
+    }
+  }
 }
 
 const baseMimes: Record<string, string> = {