Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: request param #2088

Merged
merged 1 commit into from
Jan 27, 2024
Merged

refactor: request param #2088

merged 1 commit into from
Jan 27, 2024

Conversation

ariskemper
Copy link
Contributor

@ariskemper ariskemper commented Jan 26, 2024 •
edited
Loading

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

@ariskemper ariskemper marked this pull request as draft January 26, 2024 10:17
@ariskemper ariskemper force-pushed the refactor-request-param branch from 0a37403 to 3a65266 Compare January 26, 2024 10:19
@ariskemper ariskemper marked this pull request as ready for review January 26, 2024 23:18
@ariskemper ariskemper changed the title Refactor request param refactor: request param Jan 26, 2024
yusukebe
yusukebe approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Became very clean! Thanks!

@yusukebe yusukebe merged commit b0cac62 into honojs:main Jan 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusukebe yusukebe yusukebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ariskemper @yusukebe