fix(node-ws): allow Hono with custom Env for createNodeWebSocket (#…

…951) * fix(node-ws): allow `Hono` with custom Env * add changeset
honojs · Feb 2, 2025 · c80ffbf · c80ffbf
1 parent 5cad2e1
commit c80ffbf
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/.changeset/ninety-dogs-decide.md b/.changeset/ninety-dogs-decide.md
@@ -0,0 +1,5 @@
+---
+'@hono/node-ws': patch
+---
+
+fix: allow `Hono` with custom Env for `createNodeWebSocket`
diff --git a/packages/node-ws/package.json b/packages/node-ws/package.json
@@ -9,7 +9,7 @@
     "dist"
   ],
   "scripts": {
-    "test": "vitest --run",
+    "test": "tsc --noEmit && vitest --run",
     "build": "tsup ./src/index.ts --format esm,cjs --dts",
     "publint": "publint",
     "release": "yarn build && yarn test && yarn publint && yarn publish"
@@ -48,4 +48,4 @@
   "engines": {
     "node": ">=18.14.1"
   }
-}
+}
diff --git a/packages/node-ws/src/index.test.ts b/packages/node-ws/src/index.test.ts
@@ -149,4 +149,15 @@ describe('WebSocket helper', () => {
       expect((receivedMessage as Buffer).at(idx)).toBe(val)
     })
   })
+
+  describe('Types', () => {
+    it('Should not throw a type error with an app with Variables generics', () => {
+      const app = new Hono<{
+        Variables: {
+          foo: string
+        }
+      }>()
+      createNodeWebSocket({ app })
+    })
+  })
 })
diff --git a/packages/node-ws/src/index.ts b/packages/node-ws/src/index.ts
@@ -12,7 +12,8 @@ export interface NodeWebSocket {
   injectWebSocket(server: Server | Http2Server | Http2SecureServer): void
 }
 export interface NodeWebSocketInit {
-  app: Hono
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  app: Hono<any, any, any>
   baseUrl?: string | URL
 }