feat: accept absolute-form URI for request-target #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usualoma
force-pushed
the
accept-request-for-proxy
branch
from
530c1cf to
695e1c0
Compare
usualoma
force-pushed
the
accept-request-for-proxy
branch
from
695e1c0 to
33d399d
Compare
usualoma
changed the title
|
@yusukebe |
|
Hi @usualoma I think this is perfect. Let's go with this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #228
HTTP/1.1
This PR will enable the acceptance of absolute-forms as defined in RFC 9112.
https://datatracker.ietf.org/doc/html/rfc9112#section-3.2.2
HTTP/2
In HTTP/2, the request target is specified by ":scheme", ":authority", and ":path", so absolute-form cannot be used for ":path" (it will be treated as an invalid request and will throw an error).
With this PR, however, HTTP/2 will now refer to the ":scheme" in the request header, rather than being fixed at "https".