feat: add urgency support for Windows #256
Open
+90
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds cross-platform urgency support by implementing urgency levels for Windows notifications, which were previously only available on Linux/BSD (XDG) systems. Changes: - Add urgency field to Windows Notification struct - Map Urgency levels to Windows toast scenarios: - Low/Normal → Default scenario (standard behavior) - Critical → Reminder scenario (stays on screen until dismissed) - Update urgency() method to work on Windows - Update compatibility matrix to show Windows urgency support - Update urgency example to work on both Windows and Linux/BSD The Critical urgency mapping to Reminder scenario aligns with the XDG specification's intent that critical notifications should not timeout automatically.
Owner
|
awesome, thanks for the input. unfortunately it does not build yet. would you allow me to push on your fork? |
Author
|
yes, absolutely, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds cross-platform urgency support by implementing urgency levels for Windows notifications, which were previously only available on Linux/BSD (XDG) systems.
Changes:
The Critical urgency mapping to Reminder scenario aligns with the XDG specification's intent that critical notifications should not timeout automatically.