Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject/ignore untrusted command requests #142

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Reject/ignore untrusted command requests #142

merged 6 commits into from
Jun 12, 2024

Conversation

hopsoft
Copy link
Owner

@hopsoft hopsoft commented Jun 12, 2024

No description provided.

Copy link
Collaborator

@julianrubisch julianrubisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a few questions for clarity.

Also, the boundaries of this PR aren't quite clear. In EntryMiddleware there are a few refactorings and reimplementations going on that don't seem quite related to trusted/untrusted clients.

turbo_boost-commands.gemspec Outdated Show resolved Hide resolved
@hopsoft
Copy link
Owner Author

hopsoft commented Jun 12, 2024

a few refactorings and reimplementations going on that don't seem quite related

Yes. As I dug a bit deeper and was working through getting all tests passing I realized we needed to tighten up the middleware env modificaitons. I also snuck in some additional minor refactors.

@hopsoft hopsoft merged commit 7e8d9cc into main Jun 12, 2024
8 checks passed
@hopsoft hopsoft deleted the hopsoft/bots branch June 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants