Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interprétation LaTeX par le bot lui-même #97

Merged
merged 13 commits into from
Nov 10, 2023

Conversation

Niilyx
Copy link
Contributor

@Niilyx Niilyx commented Oct 25, 2023

Pour ça j'utilise MathJax pour le parsing des formules LaTeX et Sharp pour la conversion en un .png

Il reste un problème à fix, sur certaines formules test, MathJax échoue le parsing et en réessayant tout de suite après, il y parvient.

Exemple de formule problématique :

\begin{align*}
\sum\limits_{k=1}^n u_k
&= \sum\limits_{k=1}^n (\frac{2}{k} - \frac{2}{k+2}) \\ 
&= \sum\limits_{k=1}^n \frac{2}{k} - \sum\limits_{k=1}^n \frac{2}{k+2} \\
&= \sum\limits_{k=1}^n \frac{2}{k} - \sum\limits_{k=3}^{n+2} \frac{2}{k} \\
&= \sum\limits_{k=3}^n \frac{2}{k} +2 +1 - (\sum\limits_{k=3}^{n} \frac{2}{k} + \frac{2}{n+1} + \frac{2}{n+2}) \\
&= \textcolor{blue}{\sum\limits_{k=3}^n \frac{2}{k}} + 3 \textcolor{blue}{- \sum\limits_{k=3}^{n} \frac{2}{k}} - \frac{2}{n+1} - \frac{2}{n+2} \\
&= 3 - \frac{2}{n+1} - \frac{2}{n+2}     \end{align*}

c'est-à-dire :
image

Si vous avez une idée pour fix ça, où une meilleure librairie de parsing à proposer, je suis tout ouïe

@Niilyx Niilyx marked this pull request as ready for review October 31, 2023 01:04
@Niilyx
Copy link
Contributor Author

Niilyx commented Oct 31, 2023

Bientôt y aura quelque chose d'autre qui arrivera 👀

Copy link
Collaborator

@noftaly noftaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup pour la PR et d'avoir pris le temps de trifouiller MathJax !
Quelques petites suggestions à prendre en compte, hésite pas à me contacter sur discord si t'as des questions, ou à répondre aux commentaires direct sur GitHub.

Btw le lint ne fonctionne pas, t'as du lancer npm run lint:fix mais ca ne suffit pas car il y a des choses qu'il ne peut pas régler tout seul. Je te laisse voir avec npm run lint ou en regardant l'action GitHub qui a fail

src/commands/General/latex.ts Outdated Show resolved Hide resolved
src/commands/General/latex.ts Outdated Show resolved Hide resolved
src/commands/General/latex.ts Outdated Show resolved Hide resolved
src/commands/General/latex.ts Outdated Show resolved Hide resolved
src/commands/General/latex.ts Outdated Show resolved Hide resolved
src/commands/General/latex.ts Outdated Show resolved Hide resolved
src/commands/General/latex.ts Outdated Show resolved Hide resolved
Niilyx and others added 3 commits November 10, 2023 20:49
Co-authored-by: Elliot <elliot.maisl@gmail.com>
+ import instead of require MathJax
+ eslint ignores and ts-expect-error
+ Corrected indentation
+ Made function _tryToGenerate more independent
+ English comments :trollface:
@Niilyx Niilyx requested a review from noftaly November 10, 2023 20:52
Copy link
Collaborator

@noftaly noftaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Merci beaucoup !

+ No more latex API link
+ Added Thanks for Idir :)
@noftaly noftaly merged commit 4ff11cc into horizon-efrei:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants