When removing waypoints for terrain following with waylines, resequence index numbers #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPML index numbers need to be sequential
When we create large terrain following flight plans, we then trim them to remove waypoints that are not needed to maintain Altitude Above Ground Level (AGL) within a specific threshold. However, when removing waypoints, the remaining waypoints no longer have sequential, incremented-by-one index numbers. The DJI controller crashes when these wayline flights are loaded.
I've modified the
terrain_following_waylines
module to run through the final set of remaining waypoints after trimming and rename the indexes sequentially.Now the trimmed wayline files load onto the controller and don't crash. However, they are fucking wiggly again, so I'll either have to add the extra straightening waypoints again (as @nrjadkry requested) or figure out another setting in the WPML to stop the stupid spline interpolation that the drone is using to create a smooth cinematic experience.