Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When removing waypoints for terrain following with waylines, resequence index numbers #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ivangayton
Copy link
Collaborator

@ivangayton ivangayton commented Nov 1, 2024

WPML index numbers need to be sequential

When we create large terrain following flight plans, we then trim them to remove waypoints that are not needed to maintain Altitude Above Ground Level (AGL) within a specific threshold. However, when removing waypoints, the remaining waypoints no longer have sequential, incremented-by-one index numbers. The DJI controller crashes when these wayline flights are loaded.

I've modified the terrain_following_waylines module to run through the final set of remaining waypoints after trimming and rename the indexes sequentially.

Now the trimmed wayline files load onto the controller and don't crash. However, they are fucking wiggly again, so I'll either have to add the extra straightening waypoints again (as @nrjadkry requested) or figure out another setting in the WPML to stop the stupid spline interpolation that the drone is using to create a smooth cinematic experience.

@ivangayton ivangayton added the bug Something isn't working label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants