Introduce Final Output and Auto Lock Tasks Fields to Improve Task Management #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
enhancement
nrjadkry
reviewed
Aug 6, 2024
src/backend/app/db/db_models.py
Outdated
| @@ -129,7 +130,10 @@ class DbProject(Base): | |||
| ), | |||
| ) | |||
| author = relationship(DbUser, uselist=False, backref="user") | |||
|
|
|||
| final_output = cast( | |||
There was a problem hiding this comment.
this is the multiselect option. We might need an array field ?
There was a problem hiding this comment.
I’ve updated the schema & field to use an array field to better handle multiple selections.
for more information, see https://pre-commit.ci
nrjadkry
reviewed
Aug 7, 2024
src/backend/app/db/db_models.py
Outdated
| @@ -129,7 +130,8 @@ class DbProject(Base): | |||
| ), | |||
| ) | |||
| author = relationship(DbUser, uselist=False, backref="user") | |||
|
|
|||
| final_output = cast(list, Column(ARRAY(Enum(FinalOutput)))) | |||
| auto_lock_tasks = cast(bool, Column(Boolean, default=False)) | |||
There was a problem hiding this comment.
It is better to rename this auto_lock_tasks to something like requires_approval_from_manager_for_locking.
Fields should be named clearly.
nrjadkry
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces two new fields,
final_outputandauto_lock_tasks, to theDbProjectmodel and addresses issues with specific API endpoints. Thefinal_outputfield allows for storing the desired output format for a project, enhancing flexibility and clarity in project configurations. Theauto_lock_tasksfield provides project creators with the option to enable or disable automatic task locking, giving more control over task management.New Features:
1. Added
final_outputField:final_outputfield in theDbProjectmodel to store the output format (To store the desired output format for a projec).2. Added
auto_lock_tasksField:auto_lock_tasksfield to define whether task auto-locking is optional for the project creator.Issue Fixes:
1. Fixed Delete Project Endpoint:
/api/projects/{project_id}2. Fixed Get Pending Requested Tasks Endpoint:
/api/tasks/requested_tasks/pending