-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/task stats endpoint #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
backend
Related to backend code
migration
labels
Aug 8, 2024
nrjadkry
reviewed
Aug 8, 2024
src/backend/app/tasks/task_routes.py
Outdated
@@ -19,6 +19,116 @@ | |||
) | |||
|
|||
|
|||
@router.post("/{task_id}") | |||
async def create_task_comment( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need seperate endpoint for task comment. Can we use the task events update with state as comment
and messgae with the comment message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request introduces several updates to task-related endpoints in the API, including functionality for creating or updating task comments, retrieving task details, and fetching task statistics for the authenticated user.
Changes:
create_task_comment
: Updated to handle updating task comments and sets the task state to"UNFLYABLE_TASK"
.read_task
: Retrieves detailed information about a specific task by its ID.get_task_stats
: Fetches task statistics for the authenticated user, including counts of ongoing, request logs, completed, and unflyable tasks.