Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert splash background image from png --> compressed jpg #461

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Feb 3, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

  • The background image of the home/splash page is far too big - 1MB+
  • It's also a .png instead of .jpg.
  • The page rendering time is greatly reduced having to load this large payload.
  • JPEG compression is much more efficient for lossy images such as this, reducing the image size by 10x --> ~70KB.

Screenshots

Compressed and zoomed it it still looks fine as a background:

image

Checklist before requesting a review

  • πŸ“– Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
  • πŸ‘·β€β™€οΈ Create small PRs. In most cases, this will be possible.
  • βœ… Provide tests for your changes.
  • πŸ“ Use descriptive commit messages.
  • πŸ“— Update any related documentation and include any relevant screenshots.

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock self-assigned this Feb 3, 2025
@github-actions github-actions bot added enhancement New feature or request frontend labels Feb 3, 2025
@nrjadkry nrjadkry merged commit dd8f5f6 into develop Feb 4, 2025
2 checks passed
@spwoodcock spwoodcock deleted the refactor/small-bg-img branch February 4, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants