-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matomo cookie / tracking acceptance banner #464
Conversation
Do you think is necessary to have tracking with cookies? we could have visit metrics without cookies, which means that we wouldn't need the annoying "About the information we collect" acceptance banner. This would do it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this PR, I would use the Matomo script for tracking without cookies.
What do you think?
Cookies are used for authentication. They don't have any tracking, and are purely functional, but don't we need the banner for GDPR compliance? |
Also as a side note, are you advocating for each project to insert its own matomo script, instead of standardising it in the web component? I sense a reluctance to use the components, so just want to understand any reasoning π |
You don't need the banner for authentication, consent is needed for cookies that are not strictly necessary (ref: https://europa.eu/youreurope/business/dealing-with-customers/data-protection/online-privacy/index_en.htm). I don't have an opinion on how the script should be inserted, we need it for obtaining metrics about usage of tools (ex: number of unique visitors) it could be trough a web component if you think that's the best approach. All other HOT tools already have the script implemented. |
What type of PR is this? (check all applicable)
Related Issue
Anticipates merge of #463
the only change here is actually to App.tsx.
Describe this PR
Note
I had to do a hacky workaround using
style={{position: 'fixed', bottom: '0%'}}
for fixed position on the screen.This is due to hotosm/ui#72, so could be removed once fixed.
Screenshots
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?