Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KPI Integration #295

Merged
merged 3 commits into from
Oct 22, 2024
Merged

KPI Integration #295

merged 3 commits into from
Oct 22, 2024

Conversation

jeafreezy
Copy link
Collaborator

What does this PR do ?

This PR integrates the KPI endpoint on the landing page and includes some small fixes like typos.

How to test ?

Visit: https://f-a-ir-emmanuels-projects-1886bda9.vercel.app

@omranlm omranlm self-requested a review October 22, 2024 07:07
const KPIs: TKPIS = [
{
figure: data?.total_models_published ?? 0,
label: APP_CONTENT.homepage.kpi.publishedAIModels,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add some format for the numbers

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean like 12k, 20k etc @omranlm ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like 1,546 instead of 1546... no worries, I will do that with other text changes ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay. Thanks!

Copy link
Contributor

@omranlm omranlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and quick

@omranlm omranlm merged commit 35a344d into hotosm:develop Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants