fix: create popup outside of async request (fix ios login) (#1167)

hotosm · Feb 2, 2024 · 03d2c7b · 03d2c7b
1 parent 304863e
commit 03d2c7b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/frontend/src/utilfunctions/login.ts b/src/frontend/src/utilfunctions/login.ts
@@ -1,15 +1,20 @@
 import { createPopup } from '@/utilfunctions/createPopup';
 
 export const createLoginWindow = (redirectTo) => {
+  // Create popup outside of request (required for Safari security)
+  const popup = createPopup('OSM Auth', '');
+
   fetch(`${import.meta.env.VITE_API_URL}/auth/osm_login/`)
     .then((resp) => resp.json())
     .then((resp) => {
-      const popup = createPopup('OSM auth', resp.login_url);
       if (!popup) {
         console.warn('Popup blocked or unavailable.');
         return;
       }
 
+      // Set URL for popup from response
+      popup.location = resp.login_url;
+
       // Get OAuth2 authorization url, extract state
       const authUrl = new URL(resp.login_url);
       const authParams = new URLSearchParams(authUrl.search);