fix: updated submission detail endpoint and params

hotosm · Mar 4, 2024 · 140c6fc · 140c6fc
1 parent 8327de0
commit 140c6fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/frontend/src/components/ProjectSubmissions/SubmissionsTable.tsx b/src/frontend/src/components/ProjectSubmissions/SubmissionsTable.tsx
@@ -59,8 +59,6 @@ const SubmissionsTable = ({ toggleView }) => {
   const [paginationPage, setPaginationPage] = useState<number>(1);
   const [submittedBy, setSubmittedBy] = useState<string | null>(null);
 
-  const encodedTaskId = environment.encode(3468);
-
   useEffect(() => {
     let count = 0;
     const filters = Object.keys(filter);
@@ -436,7 +434,7 @@ const SubmissionsTable = ({ toggleView }) => {
                 <AssetModules.VisibilityOutlinedIcon
                   className="fmtm-text-[#545454] hover:fmtm-text-primaryRed"
                   onClick={() => {
-                    navigate(`/project/${encodedId}/tasks/${encodedTaskId}/submission/${row?.meta?.instanceID}`);
+                    navigate(`/project/${encodedId}/tasks/${row?.phonenumber}/submission/${row?.meta?.instanceID}`);
                   }}
                 />{' '}
                 <span className="fmtm-text-primaryRed fmtm-border-[1px] fmtm-border-primaryRed fmtm-mx-1"></span>{' '}

diff --git a/src/frontend/src/views/SubmissionDetails.tsx b/src/frontend/src/views/SubmissionDetails.tsx
@@ -9,8 +9,7 @@ const SubmissionDetails = () => {
   const params = CoreModules.useParams();
   const encodedProjectId = params.projectId;
   const decodedProjectId = environment.decode(encodedProjectId);
-  const encodedTaskId = params.taskId;
-  const decodedTaskId = environment.decode(encodedTaskId);
+  const taskId = params.taskId;
   const paramsInstanceId = params.instanceId;
 
   const submissionDetails = useAppSelector((state) => state.submission.submissionDetails);
@@ -20,10 +19,10 @@ const SubmissionDetails = () => {
       SubmissionService(
         `${
           import.meta.env.VITE_API_URL
-        }/central/submission?project_id=${decodedProjectId}&xmlFormId=${decodedTaskId}&submission_id=${paramsInstanceId}`,
+        }/submission/task_submissions/${decodedProjectId}?task_id=${taskId}&submission_id=${paramsInstanceId}`,
       ),
     );
-  }, []);
+  }, [decodedProjectId, taskId, paramsInstanceId]);
 
   function removeNullValues(obj) {
     const newObj = {};