fix: update db relations for generating submissions (#1179)

* fix: update submission in s3

* Fix: error handling in s3

* removed optional from get_obj_from_bucket

---------

Co-authored-by: sujanadh <sujanadh07@gmail.com>

src/backend/app/db/db_models.py

@@ -371,7 +371,7 @@ class DbTaskHistory(Base):
     invalidation_history = relationship(
         DbTaskInvalidationHistory, lazy="dynamic", cascade="all"
     )
-    actioned_by = relationship(DbUser)
+    actioned_by = relationship(DbUser, overlaps="task_history_user,user")
     task_mapping_issues = relationship(DbTaskMappingIssue, cascade="all")
 
     __table_args__ = (

src/backend/app/s3.py

@@ -113,6 +113,7 @@ def get_obj_from_bucket(bucket_name: str, s3_path: str) -> BytesIO:
         response = client.get_object(bucket_name, s3_path)
         return BytesIO(response.read())
     except Exception as e:
+        log.warning(f"Failed attempted download from S3 path: {s3_path}")
         raise ValueError(str(e)) from e
     finally:
         if response:

src/backend/app/submissions/submission_crud.py

@@ -357,8 +357,9 @@ def update_submission_in_s3(
         metadata_s3_path = f"/{s3_project_path}/submissions.meta.json"
         try:
             # Get the last submission date from the metadata
-            file = get_obj_from_bucket(settings.S3_BUCKET_NAME, metadata_s3_path)
-            zip_file_last_submission = (json.loads(file.getvalue()))["last_submission"]
+            data = get_obj_from_bucket(settings.S3_BUCKET_NAME, metadata_s3_path)
+
+            zip_file_last_submission = (json.loads(data.getvalue()))["last_submission"]
             if last_submission <= zip_file_last_submission:
                 # Update background task status to COMPLETED
                 update_bg_task_sync = async_to_sync(
@@ -369,7 +370,6 @@ def update_submission_in_s3(
 
         except Exception as e:
             log.warning(str(e))
-            pass
 
         # Zip file is outdated, regenerate
         metadata = {