refactor: changed sync to async gather_all_submission_csvs (#1258)

Co-authored-by: sujanadh <sujanadh07@gmail.com>
hotosm · Feb 23, 2024 · 3212ba4 · 3212ba4
1 parent ff32c52
commit 3212ba4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/backend/app/submissions/submission_crud.py b/src/backend/app/submissions/submission_crud.py
@@ -205,15 +205,14 @@ def convert_to_osm(db: Session, project_id: int, task_id: int):
     return FileResponse(final_zip_file_path)
 
 
-def gather_all_submission_csvs(db, project_id):
+async def gather_all_submission_csvs(db, project_id):
     """Gather all of the submission CSVs for a project.
 
     Generate a single zip with all submissions.
     """
     log.info(f"Downloading all CSV submissions for project {project_id}")
 
-    get_project_sync = async_to_sync(project_crud.get_project)
-    project_info = get_project_sync(db, project_id)
+    project_info = await project_crud.get_project(db, project_id)
 
     odkid = project_info.odkid
     project_name = project_info.project_name_prefix

diff --git a/src/backend/app/submissions/submission_routes.py b/src/backend/app/submissions/submission_routes.py
@@ -90,7 +90,7 @@ async def download_submission(
         Union[list[dict], File]: JSON of submissions, or submission file.
     """
     if not (task_id or export_json):
-        file = submission_crud.gather_all_submission_csvs(db, project_id)
+        file = await submission_crud.gather_all_submission_csvs(db, project_id)
         return FileResponse(file)
 
     return await submission_crud.download_submission(