feat: navigate to submissions page when clicked on the file icon in qr popup #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun2948
approved these changes
Feb 29, 2024
spwoodcock
reviewed
Feb 29, 2024
| @@ -74,7 +78,9 @@ const TaskSectionPopup = ({ taskId, body, feature }: TaskSectionPopupPropType) = | |||
| <AssetModules.DescriptionOutlinedIcon | |||
| style={{ width: '20px' }} | |||
| className="hover:fmtm-text-primaryRed" | |||
| onClick={() => {}} | |||
| onClick={() => { | |||
| navigate(`/project-submissions/MTAwMTExMTE=?tab=table&task_id=${taskId}`); | |||
There was a problem hiding this comment.
Is this navigating to a hardcoded project url?
Shouldn't it be dynamic based on the current project page, or am I missing something?
* fix customDataExtract: extract type option remove, naming changes * fix projectSliceType: projectInfo type update
Co-authored-by: sujanadh <sujanadh07@gmail.com>
|
Looks like a merge got bodged somewhere 😄
git checkout development
git pull
git checkout feat/qr-popup-icons
git rebase development |
|
@spwoodcock sorry for the mistake, I will proceed to do as you mentioned. |
|
This looks good, but still includes commits from other PRs somehow. Feel free to copy the code across to another PR if it helps 😄 |
|
@spwoodcock , I am closing this PR. I will make changes and push in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Fixes #1243
Describe this PR
This PR enables us to navigate to the submissions page when clicked on the
QR-popupfile icon with thetaskIdfilter on.Screenshots
Please provide screenshots of the change.
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?