Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uploadArea: invalid geojson error handling #1369

Merged

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Mar 20, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR solves the page crash problem whenever a geojson with empty features is uploaded.

Screenshots

image

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added the frontend Related to frontend code label Mar 20, 2024
@NSUWAL123
Copy link
Contributor Author

@spwoodcock, this approach has solved the page crash problem

@spwoodcock
Copy link
Member

Very nice work πŸ™Œ

@spwoodcock spwoodcock merged commit d87cd3d into hotosm:development Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants