Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure task_id field is always included with submissions #1589

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #1581

Describe this PR

  • The task_id field was not mandatory on the XLSForms, but was required for the submission table filtering in FMTM.
  • I updated osm-fieldwork XLSForms to have a mandatory task_id field, that is calculated from the Entity task_id.
  • The existing task_id field was renamed to task_filter and is only used to filter features by the task area in ODK Collect (field ignored if a feature is already selected).

Review Guide

  • Easiest to test on dev / staging, or using cloudflare tunnels: just --unstable start tunnel.
  • The entire mapping flow can be complete using the tunnel url for odk central.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock
Copy link
Member Author

Fixes the submission_table endpoint and submission table in the frontend
@Sujanadh @manjitapandey

@spwoodcock spwoodcock merged commit 56baab2 into development Jun 20, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/xlsform-task-id branch June 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant