Simplify infographics API usage (reuse Entities data) #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntend replacing api call
…list to child components
|
I have commented on previous API calls for the infographics for now. Once QA is done, I will remove all those commented API call codes. |
|
It's ok to remove the commented code, as we still have a record in Git & can revert to the previous code easily 👍 There are some minor pre-commit linting issues though: |
|
Sure, I will have look on those |
…t date functions to utils
|
@spwoodcock, although I fixed the spelling pre-commit error again it's showing the error though the code has been modified. |
|
Looks all good now! |
spwoodcock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
This PR contains work to calculate the submissions count on the frontend for
Form Submissions,Mapped vs Validatedcharts, and card counts.For now I have commented the frontend API calls for the Submissions chart, once it's QA done then I will remove the code.
Screenshots