Prevent project generation if api failure #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spwoodcock
added this to the (2024.4.0) stable release bugfixes / improvements milestone
NSUWAL123
approved these changes
Jul 5, 2024
|
@spwoodcock, what approach can we take in this scenario:
|
|
I think that's a very good idea 👍 Call delete project so the user can try again |
7 tasks
github-actions
bot
added
docs
* fix(hotfix): download of basemaps in ui, max zoom level 22 used for tms * ci: update all gh-workflows to latest v1.6.0 * build: upgrade rclone --> v1 pin to avoid CVE-2024-24790 * build: remove unnecessary tables and field from db schema (#1623) * build: remove unnecessary tables via migration & simplify schema * refactor: remove references to removed tables in sqlalchemy models * build: add IF EXISTS to DROP COLUMN in migration * build: remove default columns from previous migration * fix(backend): minor fixes to HTTPException on endpoints * fix(backend): addded created date on the project response, set expiry of access token to 1 hour (#1633) * docs: add placeholder for axiom repo activity * fix(createProjectSlice): set generateProject & drawToggle status to default * feat(commonUtils): isStatusSuccess function add * test: get the detailed task history for a project (#1626) * build(backend): add async-lru dep, remove cpuinfo dep * fix: replace lru_cache with async for getting odk creds * fix(splitTasks): dependency add to useEffect * fix(createProjectService): halt project creation if api failure --------- Co-authored-by: spwoodcock <sam.woodcock@protonmail.com> Co-authored-by: Sam <78538841+spwoodcock@users.noreply.github.com> Co-authored-by: Sujan Adhikari <109404840+Sujanadh@users.noreply.github.com> Co-authored-by: Azhar Ismagulova <31756707+azharcodeit@users.noreply.github.com>
spwoodcock
force-pushed
the
fix/stop-proj-generation
branch
from
21ae3f3
to
fceafd9
Compare
github-actions
bot
removed
docs
|
I merged the other PR then rebased this to It should only include the edits made 🙏 |
|
Working nicely for me! Great job Nishit 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Describe this PR
generateProjectErrorandgenerateProjectSuccess.generateProjectSuccessis set to true, then the watcher inSplitTasks.tsxwill display a success message and do the redirect.generateProjectErroris set at any stage, then the remaining project creation stages should stop - I didn't get to implement this, could you take a look please?Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?