Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update split-by-square to avoid creating tasks with no features in it #1642

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

Sujanadh
Copy link
Collaborator

@Sujanadh Sujanadh commented Jul 11, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR now avoids creating tasks with no features in them when the AOI is split using the split_by_square algorithm.

Data extracts are now passed to the logic in order to check if a task has any features in it or not. In case a task does not have any features inside it, it won't be appended to the list of tasks generated by the algorithm.

Screenshots

AOI and data extracts used:

image

Before:

Screenshot from 2024-07-09 13-51-37

After:

Screenshot from 2024-07-09 13-47-48

Dependency

This PR depends on the release of fmtm-splitter.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh self-assigned this Jul 11, 2024
@github-actions github-actions bot added frontend Related to frontend code backend Related to backend code labels Jul 11, 2024
@Sujanadh Sujanadh added enhancement New feature or request priority:high Should be addressed as a priority dependency:fmtm-splitter Requires updates in fmtm-splitter dependency Related to a software dependency and removed dependency Related to a software dependency labels Jul 11, 2024
@spwoodcock spwoodcock merged commit a1665f2 into development Jul 12, 2024
7 checks passed
@spwoodcock spwoodcock deleted the fix/split-by-square branch July 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code dependency:fmtm-splitter Requires updates in fmtm-splitter enhancement New feature or request frontend Related to frontend code priority:high Should be addressed as a priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants