Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save current form step state on previous btn click #1643

Merged

Conversation

NSUWAL123
Copy link
Collaborator

@NSUWAL123 NSUWAL123 commented Jul 11, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

Currently in the steps upload area, select category, and split tasks, when the previous button is clicked after filling fields respectively, file states are being saved but the dropdowns, radiobuttons state is not saved leading to displaying misleading error messages.
This PR contain the works to solve this by saving the state of the current step when the previous button is clicked.

Screenshots

Before Changes:
Screencast from 11-7-24 09:48:44 ΰ€ͺΰ₯‚ΰ€°ΰ₯ΰ€΅ΰ€Ύΰ€Ήΰ₯ΰ€¨ +0545.webm

After Changes:
Screencast from 11-7-24 09:52:22 ΰ€ͺΰ₯‚ΰ€°ΰ₯ΰ€΅ΰ€Ύΰ€Ήΰ₯ΰ€¨ +0545.webm

Alternative Approaches Considered

Removing the current selected state and files if previous btn was clicked and next btn was not clicked was considered as an alternative but in terms of user experience and extra step of entering same fields and files for the users would be hectic.

@github-actions github-actions bot added the frontend Related to frontend code label Jul 11, 2024
@NSUWAL123 NSUWAL123 changed the title ave current form step state on previous btn c… Save current form step state on previous btn click Jul 11, 2024
@spwoodcock
Copy link
Member

Good job finding this πŸ‘

@spwoodcock spwoodcock merged commit b97b3bd into hotosm:development Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants