Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multipolygons to choose as task area #1645

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Sujanadh
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR addresses issue of not supporting multipolygons to upload as a project aoi.
Updates:

  • when multipolygons are uploaded as an aoi, those polygons gets dissolved to create a single aoi
  • if we want to split task without dissolving those polygons we can pass dissolve_polygon = False since task-splitter can splits those separate polygons
  • we can ask for a param (dissolve_polygons = True/False)from user if they want to dissolve those polygons while splitting it (not implemented yet)

Screenshots

Provided in the mentioned issue.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock July 11, 2024 09:27
@Sujanadh Sujanadh self-assigned this Jul 11, 2024
@github-actions github-actions bot added the backend Related to backend code label Jul 11, 2024
@spwoodcock
Copy link
Member

I think having to ask the user overcomplicates it for them.

From the user perspective they just want to upload a geojson and have it work.

If they upload a multipolygon, can we:

  • Support dissolving to a single polygon for downloading a data extract (already works).
  • Allow the user to Choose area as task, to creates a task from each polygon in the multipolygon.
  • Allow the user to Split by square or Splitting algorithm by dissolving the multipolygon into a single polygon.

Do you think this is possible?

@Sujanadh
Copy link
Contributor Author

Sujanadh commented Jul 11, 2024

I think all the mentioned criteria can be achieved with this PR; dissolving polygon wasn't there incase of disjoint polygons if any, this PR solves it too.
User deciding to dissolve the polygon hasn't been implemented, though I just had a thought about it.
So, this PR is ready to get merged.

@spwoodcock spwoodcock merged commit 405017a into development Jul 11, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/multi-polygon-aoi branch July 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants