Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/staging bugs #1810

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix/staging bugs #1810

merged 2 commits into from
Sep 26, 2024

Conversation

NSUWAL123
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • QRcode size increase
  • taskId filter add to ODK redirection

@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code labels Sep 26, 2024
@NSUWAL123 NSUWAL123 merged commit 32750b1 into staging Sep 26, 2024
5 of 6 checks passed
@NSUWAL123 NSUWAL123 deleted the fix/staging-bugs branch September 26, 2024 11:30
@@ -232,7 +232,7 @@ export default function Dialog({ taskId, feature }: dialogPropType) {
);

if (isMobile) {
document.location.href = `odkcollect://form/${projectInfo.xform_id}`;
document.location.href = `odkcollect://form/${projectInfo.xform_id}?task_filter=${taskId}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually removed intentionally, as I deemed the task_filter param to be unnecessary - it confused things I think!

The custom ODK Collect should be default, then backup users can just select the geom they are standing next too quite easily with geolocation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manjitapandey not sure if you agree, but I think it's ok for 'Go to ODK' to just open the unfilled form

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, when users access ODK at the task level, they are presented with all the project's features, which may cause confusion as they likely expect to see only the features relevant to the specific task. Skipping the task-specific question might not be a good idea in this context.

Copy link
Member

@spwoodcock spwoodcock Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But should we actually even have that as a flow? The main one we should target is building selection, not task id selection.

From what I have seen actual mapping in practice is that the task id selection question is a source of confusion. Perhaps we should get some feedback from recent users.

I personally don't see it as much of an issue having the buildings loaded for users in the field. I agree it's difficult to select a building on a remote computer with no geolocation, but when in the field you are geolocated to show a dot next to the building to be mapped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants