-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection of basemap output formats, TMS input, mobile UI #896
Conversation
@spwoodcock sounds good to me will have a look onto this branch aswell thanks for the feature on both side frontend backend . |
@spwoodcock i am having this issue on this branch on my local server any idea ?
|
This needs a new release of osm-fieldwork. You can bind mount a local version - see the dev backend docs 👍 |
096c1f7
to
e8fbd8c
Compare
@spwoodcock now using development version of osm-fieldwork, I am getting error like this |
You need to rebuild the backend image using this branch. It has the |
Nice 🤩 The migration looks good 👍 I was determining the format using the file extension - I'll have to check the download endpoint - we can probably use this new field instead. (I understand the new field is required to display the format without downloading the file). Just fyi, I don't really envision the pmtiles format will be requested by a user, as it's an online only format (although they could, so we can give the option. The idea of pmtiles was to:
|
Yeah Hmm about the PMtiles it was just requested by Rob so i guess we went ahead and did it for PMTiles too but i understand what you're trying to say. |
for more information, see https://pre-commit.ci
5230e18
to
063a075
Compare
for more information, see https://pre-commit.ci
Note: this requires osm-fieldwork v0.3.7 or v0.4.0
I quickly made the PR as I had been working on osm-fieldwork basemapper.py and had it fresh in my head (avoid context switching).
Fixes #839 and fixes #586
@varun2948 I didn't spend too long on the UI part. I didn't want to duplicate work you may be doing already. But I just made it work on mobile as well as desktop 👍