Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend tests for project endpoints #900

Merged
merged 65 commits into from
Oct 17, 2023
Merged

Backend tests for project endpoints #900

merged 65 commits into from
Oct 17, 2023

Conversation

Sujanadh
Copy link
Contributor

@Sujanadh Sujanadh commented Oct 11, 2023

Fixes #169

This pull request contains the updated test data within a compressed zip file. It encompasses all the modifications made in my previous pull request, which was PR #870 in the forked repository. We can close the old pull request.

@spwoodcock spwoodcock changed the title removed the larger geojson file with compressed zip in test_data Backend tests for project endpoints Oct 11, 2023
@spwoodcock spwoodcock mentioned this pull request Oct 11, 2023
@spwoodcock
Copy link
Member

Thanks @Sujanadh! I will review this tomorrow 👍

Quick note: I think the test_data dir should go under tests not app in the backend dir.

@robsavoye
Copy link
Collaborator

I think it does need to be called tests, and be more top level so pytest works. Btw, thank you for adding tests! This is something FMTM is seriously lacking, so every little bit helps.

@spwoodcock
Copy link
Member

Also, check the failing tests in the pytest run - they are showing valid errors.
E.g. the file /opt/app/test_data/building_footprint.zip is missing from the PR.

@nrjadkry
Copy link
Contributor

@spwoodcock pytest does not find the tests written outside the app directory. We might need to fix that to write the tests outside of app directory.

@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 12:14 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 12:31 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 12:57 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 13:25 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 13:27 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 13:31 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 13:42 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 13:47 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 14:04 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 14:09 — with GitHub Actions Inactive
@spwoodcock spwoodcock merged commit 5036c10 into development Oct 17, 2023
6 of 7 checks passed
@spwoodcock spwoodcock deleted the feat-test-case branch October 17, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code devops Related to deployment or configuration
Projects
Development

Successfully merging this pull request may close these issues.

Add test cases (priority create project endpoints) Create test cases for backend API
4 participants